fix: index out-of-bounds issue in the LT05 rule when trying to remove elements from a sequence #1038
+38
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @bradleyess, Thank you so much for your contribution. I am slightly worried about this in its current shape. We don't currently support the Jinja template and so I am not sure your test proves the fix: I think we skip the test for templates we don't have yet. I am looking at the Jinja templater right now, so I can look into this after that having finished it. If you can prove that this test fails without any jinja that could be really helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
sqruffon a DBT model in Snowflake dialect, theLT05rule was panicking. This only removes the indexes when they exist, otherwise prints.Error: